Update webhook cert-manager install to work with GKE autopilot clusters #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardsliu
reviewed
Apr 12, 2024
richardsliu
approved these changes
Apr 15, 2024
|
/gcbrun |
alpha-amundson
pushed a commit
that referenced
this pull request
May 3, 2024
…rs (#585) * Change install-cert-manager to work with autopilot clusters * Add cert-manager install commands to TPU_GUIDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
make install-cert-managercommand to one that works for both GKE standard and autopilot clusters. The previouskubectl applycommand to install cert-manager is incompatible with GKE autopilot since the defaultglobal.leaderElection.namespaceis a managed namespace on autopilot.This PR was tested by installing cert-manager using the helm commands on both standard and autopilot clusters and verifying that the webhook was successfully issued a certificate.