-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the default GKE cluster type for jupyterhub to GKE Autopilot. #599
Set the default GKE cluster type for jupyterhub to GKE Autopilot. #599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments on referencing AP and variable ordering.
cluster_name = "ml-cluster" | ||
cluster_location = "us-central1" | ||
cluster_membership_id = "" # required for private cluster, defaults to `cluster_name` | ||
autopilot_cluster = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move this up to be with create_cluster so the variables are together since they are related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of the flags in this section are related to the create cluster (cluster name, location, type, fleet membership). I've moved the flag up one line, but since I expect that it's more likely to change the cluster name or location than the type, I'd prefer to leave it below those two variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restructured a bit more so that the terraform lint check would pass.
0c118b1
to
ba46585
Compare
Also add instructions to use a standard cluster if preferred.
ba46585
to
1e8b7ed
Compare
/gcbrun |
Also add instructions to use a standard cluster if preferred.
…ogleCloudPlatform#599) Also add instructions to use a standard cluster if preferred.
Also add instructions to use a standard cluster if preferred.
Also add instructions to use a standard cluster if preferred.
Also add instructions to use a standard cluster if preferred.