Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genai on gke #663

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Genai on gke #663

wants to merge 14 commits into from

Conversation

psabhishekgoogle
Copy link
Collaborator

No description provided.

@psabhishekgoogle psabhishekgoogle enabled auto-merge (squash) May 7, 2024 17:14
@andrewsykim
Copy link
Collaborator

All terraform solutions in applications/* are required to have e2e tests as part of presubmit check. See https://github.com/GoogleCloudPlatform/ai-on-gke/blob/main/cloudbuild.yaml for example e2e tests for applications/ray, applications/jupyter and applications/rag. Can you add tests in this PR please?

@roberthbailey
Copy link
Collaborator

Right now this application exists on the genai-on-gke branch but not the main branch. Do you expect to maintain it on the main branch (and in subsequent v1.x releases) going forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@psabhishekgoogle @andrewsykim @roberthbailey