-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker file for pytorch #674
base: main
Are you sure you want to change the base?
Conversation
/gcbrun |
@@ -4,8 +4,7 @@ | |||
FROM ubuntu:22.04 | |||
|
|||
ENV DEBIAN_FRONTEND=noninteractive | |||
ENV PYTORCH_JETSTREAM_VERSION=jetstream-v0.2.0 | |||
ENV JETSTREAM_VERSION=v0.2.0 | |||
ENV PYTORCH_JETSTREAM_VERSION=v0.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the latest stable branch, any breaking changes to the existing functionalities?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no breaking changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jetstream latest release is v0.2.1, why is pytorch on a later release and not in sync with the Jetstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a particular commit: google/JetStream#84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, has this dockerfile been built and tested on GKE yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like 3096a0e#diff-32a8afd80b59d025388e8c0291592744fa2819f928908d65d62cc85518234fe0 was submitted and accounts for this change. Could we close this PR then?
when using jetstream-pytorch, one should not install Jetstream again.
install-everything.sh
script will install a particular version of Jetstream, please don't overwrite it.