Update docker file for pytorch #674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
liurupeng
approved these changes
May 20, 2024
liurupeng
reviewed
May 20, 2024
| @@ -4,8 +4,7 @@ | |||
| FROM ubuntu:22.04 | |||
|
|
|||
| ENV DEBIAN_FRONTEND=noninteractive | |||
| ENV PYTORCH_JETSTREAM_VERSION=jetstream-v0.2.0 | |||
| ENV JETSTREAM_VERSION=v0.2.0 | |||
| ENV PYTORCH_JETSTREAM_VERSION=v0.2.2 | |||
There was a problem hiding this comment.
this is the latest stable branch, any breaking changes to the existing functionalities?
There was a problem hiding this comment.
Jetstream latest release is v0.2.1, why is pytorch on a later release and not in sync with the Jetstream?
There was a problem hiding this comment.
We need a particular commit: google/JetStream#84
There was a problem hiding this comment.
Thanks, has this dockerfile been built and tested on GKE yet?
There was a problem hiding this comment.
Looks like 3096a0e#diff-32a8afd80b59d025388e8c0291592744fa2819f928908d65d62cc85518234fe0 was submitted and accounts for this change. Could we close this PR then?
vivianrwu
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using jetstream-pytorch, one should not install Jetstream again.
install-everything.shscript will install a particular version of Jetstream, please don't overwrite it.