feat: add support for FUSE #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a port of GoogleCloudPlatform/cloud-sql-proxy#1381. Fixes #132.
enocom
commented
Sep 15, 2022
| } | ||
|
|
||
| const readmeText = ` | ||
| When applications attempt to open files in this directory, a remote connection |
There was a problem hiding this comment.
I updated the README for AlloyDB.
enocom
commented
Sep 15, 2022
internal/proxy/proxy.go
Outdated
| return c.NewInode(ctx, &readme{}, fs.StableAttr{}), fs.OK | ||
| } | ||
|
|
||
| instanceURI, err := toFullURI(instance) |
There was a problem hiding this comment.
This check expands the requested instance (e.g., proj.region.cluster.inst) into a full instance URI. If instance isn't a valid short Unix name, it returns an error.
hessjcg
suggested changes
Sep 15, 2022
hessjcg
approved these changes
Sep 16, 2022
| @@ -151,10 +160,13 @@ var ( | |||
| // 'projects/<PROJECT>/locations/<REGION>/clusters/<CLUSTER>/instances/<INSTANCE>' | |||
| // Additionally, we have to support legacy "domain-scoped" projects (e.g. "google.com:PROJECT") | |||
| instURIRegex = regexp.MustCompile("projects/([^:]+(:[^:]+)?)/locations/([^:]+)/clusters/([^:]+)/instances/([^:]+)") | |||
There was a problem hiding this comment.
Optional Nit: If you wanted to be really clever, use a non-capturing group (?: ) for the sub-domain in PROJECT group
instURIRegex = regexp.MustCompile(
"projects/([^:]+(?::[^:]+)?)/locations/([^:]+)/clusters/([^:]+)/instances/([^:]+)")
Then the so that your code down below goes 1,2,3,4:
project := string(m[1])
region := string(m[2])
cluster := string(m[3])
name := string(m[4])
There was a problem hiding this comment.
Fancy -- I'm working on making this code exported from the connector and will revisit this change with unit tests when I get there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of GoogleCloudPlatform/cloud-sql-proxy#1381.
Fixes #132.