Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate cache when selected IP type doesn't exist #554

Closed
enocom opened this issue Apr 19, 2024 · 0 comments · Fixed by #555 or #558
Closed

Invalidate cache when selected IP type doesn't exist #554

enocom opened this issue Apr 19, 2024 · 0 comments · Fixed by #555 or #558
Assignees
@jackwotherspoon
Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@enocom
Copy link
Member

enocom commented Apr 19, 2024

When dialing a particular IP type that isn't in the cache, the internals will currently report an error but otherwise keep the cached connection info around.

When adding a new IP type after starting the Connector, callers should be able to immediately start using that IP type once it's available in the AlloyDB API connection info response without having to restart the process.
@enocom enocom added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p0 Highest priority. Critical issue. P0 implies highest priority. labels Apr 19, 2024
enocom added a commit that referenced this issue Apr 19, 2024
@enocom
feat: invalidate cache on IP type errors
084b220 
When a caller requests an IP type not in the cache, the dialer will now
invalidate the cached connection info. This ensures the dialer will have
an up-to-date cache for subsequent requests.

Fixes #554
@enocom enocom mentioned this issue Apr 19, 2024
Merged
enocom added a commit that referenced this issue Apr 19, 2024
@enocom
feat: invalidate cache on IP type errors
ad9a7c0 
When a caller requests an IP type not in the cache, the dialer will now
invalidate the cached connection info. This ensures the dialer will have
an up-to-date cache for subsequent requests.

Fixes #554
enocom added a commit that referenced this issue Apr 26, 2024
@enocom
feat: invalidate cache on IP type errors (#555)
154ab5f 
When a caller requests an IP type not in the cache, the dialer will now
invalidate the cached connection info. This ensures the dialer will have
an up-to-date cache for subsequent requests.

Fixes #554
@release-please release-please bot mentioned this issue Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwotherspoon jackwotherspoon

Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
2 participants
@enocom @jackwotherspoon