Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample ConfigMap for otel-collector Monarch configuration #106

Conversation

tiffanny29631
Copy link

No description provided.

Copy link

snippet-bot bot commented Feb 21, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this example?

@@ -0,0 +1,165 @@
# Copyright 2024 Google LLC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit weird to create a configmaps/ folder just for this file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was putting it as a parallel with crds, let me know if there is a better location.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe add it in Config Sync repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, adding it in the CS repo seems better

@tiffanny29631
Copy link
Author

What's the purpose of this example?

This is to give an example for users who wants to opt out of GCM but keep the internal pipeline (potentially for smoke detector), before we support APIs to let user choose which pipeline to use.

@janetkuo
Copy link
Member

Is there a reason why it should be documented here, instead of https://github.com/GoogleContainerTools/kpt-config-sync?

@tiffanny29631
Copy link
Author

Moving to Config Sync repo. GoogleContainerTools/kpt-config-sync#1152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants