-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample ConfigMap for otel-collector Monarch configuration #106
Add sample ConfigMap for otel-collector Monarch configuration #106
Conversation
5ed3832
to
ef56616
Compare
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
ef56616
to
364700b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this example?
@@ -0,0 +1,165 @@ | |||
# Copyright 2024 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit weird to create a configmaps/ folder just for this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was putting it as a parallel with crds, let me know if there is a better location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe add it in Config Sync repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, adding it in the CS repo seems better
This is to give an example for users who wants to opt out of GCM but keep the internal pipeline (potentially for smoke detector), before we support APIs to let user choose which pipeline to use. |
Is there a reason why it should be documented here, instead of https://github.com/GoogleContainerTools/kpt-config-sync? |
Moving to Config Sync repo. GoogleContainerTools/kpt-config-sync#1152 |
No description provided.