Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skips submodule metdata autogen if readme isn't present #1428

Merged
merged 2 commits into from
Mar 8, 2023
Merged

fix: skips submodule metdata autogen if readme isn't present #1428

merged 2 commits into from
Mar 8, 2023

Conversation

g-awmalik
Copy link
Collaborator

No description provided.

bharathkkb
bharathkkb approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @g-awmalik
Would be good to add a test

cli/bpmetadata/cmd.go Outdated Show resolved Hide resolved
cli/bpmetadata/cmd.go Outdated Show resolved Hide resolved
@g-awmalik g-awmalik merged commit a87b654 into master Mar 8, 2023
@g-awmalik g-awmalik deleted the fix/bpmeta-submodule-fix branch March 8, 2023 19:25
@g-awmalik g-awmalik mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@apeabody apeabody Awaiting requested review from apeabody

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-awmalik @bharathkkb