-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libraries BOM: Google Cloud BOM 0.172.0 and associated dependencies #2298
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
<gax.version>2.13.0</gax.version> | ||
<gax.httpjson.version>0.98.0</gax.httpjson.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shared dependencies BOM 2.9.0 has GAX 2.13.0. GAX BOM 2.13.0 (https://search.maven.org/artifact/com.google.api/gax-bom/2.13.0/pom) has gax-httpjson 0.98.0.
<guava.version>31.0.1-jre</guava.version> | ||
<guava.version>31.1-jre</guava.version> | ||
<gson.version>2.9.0</gson.version> | ||
<google.cloud.bom.version>0.171.0</google.cloud.bom.version> | ||
<google.cloud.core.version>2.5.6</google.cloud.core.version> | ||
<io.grpc.version>1.44.1</io.grpc.version> | ||
<http.version>1.41.4</http.version> | ||
<google.cloud.bom.version>0.172.0</google.cloud.bom.version> | ||
<google.cloud.core.version>2.5.11</google.cloud.core.version> | ||
<io.grpc.version>1.45.0</io.grpc.version> | ||
<http.version>1.41.5</http.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the Google Cloud BOM 0.172.0, these changes come from the shared dependencies BOM 2.9.0
https://github.com/googleapis/java-shared-dependencies/blob/v2.9.0/first-party-dependencies/pom.xml
<auth.version>1.6.0</auth.version> | ||
<api-common.version>2.1.5</api-common.version> | ||
<common.protos.version>2.8.0</common.protos.version> | ||
<iam.protos.version>1.2.10</iam.protos.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -47,21 +47,21 @@ | |||
|
|||
<properties> | |||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
<guava.version>31.0.1-jre</guava.version> | |||
<guava.version>31.1-jre</guava.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we missing a number here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest assured. Guava's release has sometimes 2 numbers and other times 3 numbers.
https://search.maven.org/artifact/com.google.guava/guava
(Also we have a check to ensure the artifacts in the BOM exists in Maven Central. It would catch any typo in version or artifact IDs)
Google Cloud BOM 0.172.0 was released. The client libraries were built and tested with the shared dependencies BOM 2.9.0 (https://github.com/googleapis/java-shared-dependencies/blob/v2.9.0/first-party-dependencies/pom.xml). Upgrading the associated dependencies in the BOM too as usual.
It has GAX 2.13.0. GAX BOM 2.13.0 (https://search.maven.org/artifact/com.google.api/gax-bom/2.13.0/pom) has gax-httpjson 0.98.0.