Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries BOM: Google Cloud BOM 0.172.0 and associated dependencies #2298

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

suztomo
Copy link
Contributor

@suztomo suztomo commented Mar 31, 2022

Google Cloud BOM 0.172.0 was released. The client libraries were built and tested with the shared dependencies BOM 2.9.0 (https://github.com/googleapis/java-shared-dependencies/blob/v2.9.0/first-party-dependencies/pom.xml). Upgrading the associated dependencies in the BOM too as usual.

It has GAX 2.13.0. GAX BOM 2.13.0 (https://search.maven.org/artifact/com.google.api/gax-bom/2.13.0/pom) has gax-httpjson 0.98.0.

@suztomo suztomo added the kokoro:run force run kokoro label Mar 31, 2022
@cloud-tools-for-java-team cloud-tools-for-java-team removed the kokoro:run force run kokoro label Mar 31, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@suztomo suztomo requested review from mpeddada1 and a team March 31, 2022 13:38
Comment on lines +59 to +60
<gax.version>2.13.0</gax.version>
<gax.httpjson.version>0.98.0</gax.httpjson.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shared dependencies BOM 2.9.0 has GAX 2.13.0. GAX BOM 2.13.0 (https://search.maven.org/artifact/com.google.api/gax-bom/2.13.0/pom) has gax-httpjson 0.98.0.

Comment on lines -50 to +55
<guava.version>31.0.1-jre</guava.version>
<guava.version>31.1-jre</guava.version>
<gson.version>2.9.0</gson.version>
<google.cloud.bom.version>0.171.0</google.cloud.bom.version>
<google.cloud.core.version>2.5.6</google.cloud.core.version>
<io.grpc.version>1.44.1</io.grpc.version>
<http.version>1.41.4</http.version>
<google.cloud.bom.version>0.172.0</google.cloud.bom.version>
<google.cloud.core.version>2.5.11</google.cloud.core.version>
<io.grpc.version>1.45.0</io.grpc.version>
<http.version>1.41.5</http.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the Google Cloud BOM 0.172.0, these changes come from the shared dependencies BOM 2.9.0
https://github.com/googleapis/java-shared-dependencies/blob/v2.9.0/first-party-dependencies/pom.xml

Comment on lines +61 to +64
<auth.version>1.6.0</auth.version>
<api-common.version>2.1.5</api-common.version>
<common.protos.version>2.8.0</common.protos.version>
<iam.protos.version>1.2.10</iam.protos.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -47,21 +47,21 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<guava.version>31.0.1-jre</guava.version>
<guava.version>31.1-jre</guava.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we missing a number here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest assured. Guava's release has sometimes 2 numbers and other times 3 numbers.

https://search.maven.org/artifact/com.google.guava/guava

(Also we have a check to ensure the artifacts in the BOM exists in Maven Central. It would catch any typo in version or artifact IDs)

@suztomo suztomo merged commit 669eb70 into master Mar 31, 2022
@suztomo suztomo deleted the gcb_0.172.0 branch March 31, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants