BomContentTest disableMavenCentralCheck property #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeli0
reviewed
Jul 8, 2022
|
|
||
| // Sometimes the artifacts are not yet available in Maven Central and only available in local | ||
| // Maven repository. Use | ||
| boolean enableMavenCentralAvailabilityCheck = |
There was a problem hiding this comment.
The variable name is the opposite of the property name, can we keep them consistent? Either disableMavenCentralCheck or enableMavenCentralAvailabilityCheck?
suztomo
force-pushed
the
skip_maven_central_check_option
branch
from
fd064cc to
850d19d
Compare
blakeli0
reviewed
Jul 8, 2022
| // Sometimes the artifacts are not yet available in Maven Central and only available in local | ||
| // Maven repository. Use this property in that case. | ||
| boolean disableMavenCentralCheck = | ||
| ! "true".equals(System.getProperty("disableMavenCentralCheck")); |
There was a problem hiding this comment.
I think we should also remove ! here as well.
blakeli0
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some artifacts are not available in Maven Central yet, use "-DdisableMavenCentralCheck=true" system property when running BomContentTest.