Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup allstar ignore file for binary files #2324

Merged
merged 6 commits into from
Jan 30, 2023
Merged

Setup allstar ignore file for binary files #2324

merged 6 commits into from
Jan 30, 2023

Conversation

suztomo
Copy link
Contributor

@suztomo suztomo commented Jan 24, 2023 •
edited
Loading

Fixes #2322. Following http://go/allstar#faq instructions. This repository has binary files it uses for tests.

  • Adjusting Allstar binary file alerts
  • Not to add Maven wrapper JAR file

@suztomo suztomo changed the title allstar ignore file Setup allstar ignore file for binary files Jan 24, 2023
suztomo
suztomo commented Jan 24, 2023
View reviewed changes
.allstar/binary_artifacts.yaml
Comment on lines +3 to +4
- enforcer-rules/src/test/resources/dummy-0.0.1.jar
- example-problems/gradle-project/build/classes/java/main/App.class
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The automation has been complaining the two files that this repository uses for tests
#2322

@suztomo
Copy link
Contributor Author

suztomo commented Jan 24, 2023

kokoro-macos failed due to Java 14...

[ERROR] Command line was: /Library/Java/JavaVirtualMachines/jdk-14.0.1.jdk/Contents/Home/bin/javadoc @options @packages
[ERROR] 
[ERROR] Refer to the generated Javadoc files in '/Volumes/BuildData/tmpfs/src/github/cloud-opensource-java/dependencies/target/apidocs' dir.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]

Checking how to use Java 11 there.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

suztomo
suztomo commented Jan 26, 2023
View reviewed changes
kokoro/continuous.sh
export MAVEN_OPTS="-Xmx8g"

cd github/cloud-opensource-java

./mvnw -V -B -ntp clean install javadoc:jar
./mvnw -V -B -ntp clean install -Djavadoc.skip
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't publish javadoc. This is failing with Java 14 on MacOS.

@suztomo suztomo merged commit 344dc70 into master Jan 30, 2023
@suztomo suztomo deleted the allstar_ignore_file branch June 26, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

@meltsufin meltsufin meltsufin approved these changes

@JoeWang1127 JoeWang1127 JoeWang1127 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security Policy violation Binary Artifacts
5 participants
@suztomo @lqiu96 @meltsufin @JoeWang1127 @cloud-tools-for-java-team