-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update linkage tests #2358
Merged
burkedavison
merged 8 commits into
GoogleCloudPlatform:master
from
burkedavison:fake-change
Nov 10, 2023
Merged
chore: update linkage tests #2358
burkedavison
merged 8 commits into
GoogleCloudPlatform:master
from
burkedavison:fake-change
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replicating locally, the relevant dashboard section now reads: <h3>io.grpc:grpc-netty-shaded:1.20.0</h3>
<p class="jar-linkage-report">
5 target classes
causing linkage errors referenced from
5 source classes.
</p>
<p class="jar-linkage-report-cause">Class org.conscrypt.AllocatedBuffer is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
<p class="jar-linkage-report-cause">Class org.conscrypt.Conscrypt is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
<p class="jar-linkage-report-cause">Class org.conscrypt.HandshakeListener is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
<p class="jar-linkage-report-cause">Class org.conscrypt.BufferAllocator is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
<p class="jar-linkage-report-cause">sun.security.x509.AlgorithmId's field "sun.security.util.ObjectIdentifier sha256WithRSAEncryption_oid" is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.util.OpenJdkSelfSignedCertGenerator</p>
<p class="linkage-check-dependency-paths">
The following paths contain io.grpc:grpc-netty-shaded:1.20.0:
</p>
<!-- The visibility of this list is toggled via the button above. Hidden by default -->
<ul class="linkage-check-dependency-paths"
style="display:">
<li>io.grpc:grpc-netty-shaded:1.20.0 (compile)</li>
<li>io.grpc:grpc-alts:1.20.0 (compile) / io.grpc:grpc-netty-shaded:1.20.0 (compile)</li>
</ul> With Java 8, the relevant dashboard section now reads: <h3>io.grpc:grpc-netty-shaded:1.20.0</h3>
<p class="jar-linkage-report">
4 target classes
causing linkage errors referenced from
4 source classes.
</p>
<p class="jar-linkage-report-cause">Class org.conscrypt.AllocatedBuffer is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
<p class="jar-linkage-report-cause">Class org.conscrypt.Conscrypt is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
<p class="jar-linkage-report-cause">Class org.conscrypt.HandshakeListener is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
<p class="jar-linkage-report-cause">Class org.conscrypt.BufferAllocator is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
<p class="linkage-check-dependency-paths">
The following paths contain io.grpc:grpc-netty-shaded:1.20.0:
</p>
<!-- The visibility of this list is toggled via the button above. Hidden by default -->
<ul class="linkage-check-dependency-paths"
style="display:">
<li>io.grpc:grpc-netty-shaded:1.20.0 (compile)</li>
<li>io.grpc:grpc-alts:1.20.0 (compile) / io.grpc:grpc-netty-shaded:1.20.0 (compile)</li>
</ul> |
Replicating locally and saving |
…ng-spring-repository from 107 to 108
LinkageCheckerMainIntegrationTest.testBom_java11 is currently ignored, with the following as the linkageProblems, but no known way to replicate the prior (expected) set: |
blakeli0
approved these changes
Nov 10, 2023
burkedavison
added a commit
to burkedavison/cloud-opensource-java
that referenced
this pull request
Nov 10, 2023
This reverts commit 02c26c9.
burkedavison
added a commit
to burkedavison/cloud-opensource-java
that referenced
this pull request
Nov 10, 2023
* chore: fake update * chore: @ignore LinkageCheckerMainIntegrationTest.testBom_java11 * chore: change expected linkage errors in grpc-netty-shaded from 4 to 5 * chore: change expected Linkage Checker rule errors in bom-project-using-spring-repository from 107 to 108 * chore: relocate linkage error assertion to JDK-version specific test * chore: update LinkageCheckerMainIntegrationTest expected error count * chore: remove unused import * chore: remove outdated comments (cherry picked from commit 02c26c9)
burkedavison
added a commit
that referenced
this pull request
Nov 10, 2023
* deps: bigtable 2.25.3 and bigtable-hbase-beam 2.9.2 * chore: update linkage tests (#2358) * chore: fake update * chore: @ignore LinkageCheckerMainIntegrationTest.testBom_java11 * chore: change expected linkage errors in grpc-netty-shaded from 4 to 5 * chore: change expected Linkage Checker rule errors in bom-project-using-spring-repository from 107 to 108 * chore: relocate linkage error assertion to JDK-version specific test * chore: update LinkageCheckerMainIntegrationTest expected error count * chore: remove unused import * chore: remove outdated comments (cherry picked from commit 02c26c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the linkage tests to reflect the new expected error counts, as suggested by @suztomo .