Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update linkage tests #2358

Merged
merged 8 commits into from
Nov 10, 2023

Conversation

burkedavison
Copy link
Member

@burkedavison burkedavison commented Nov 9, 2023

This PR updates the linkage tests to reflect the new expected error counts, as suggested by @suztomo .

@burkedavison
Copy link
Member Author

burkedavison commented Nov 9, 2023

[ERROR]   DashboardTest.testLinkageReports:220 value of: trimAndCollapseWhiteSpace(...)
expected: 4 target classes causing linkage errors referenced from 4 source classes.
but was : 5 target classes causing linkage errors referenced from 5 source classes.

Replicating locally, the relevant dashboard section now reads:

  <h3>io.grpc:grpc-netty-shaded:1.20.0</h3>
  <p class="jar-linkage-report">
    5 target classes
    causing linkage errors referenced from
    5 source classes.
  </p>
      <p class="jar-linkage-report-cause">Class org.conscrypt.AllocatedBuffer is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
      <p class="jar-linkage-report-cause">Class org.conscrypt.Conscrypt is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
      <p class="jar-linkage-report-cause">Class org.conscrypt.HandshakeListener is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
      <p class="jar-linkage-report-cause">Class org.conscrypt.BufferAllocator is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
      <p class="jar-linkage-report-cause">sun.security.x509.AlgorithmId&#39;s field &quot;sun.security.util.ObjectIdentifier sha256WithRSAEncryption_oid&quot; is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.util.OpenJdkSelfSignedCertGenerator</p>
  <p class="linkage-check-dependency-paths">
    The following paths contain io.grpc:grpc-netty-shaded:1.20.0:
  </p>

    <!-- The visibility of this list is toggled via the button above. Hidden by default -->
    <ul class="linkage-check-dependency-paths"
        style="display:">
          <li>io.grpc:grpc-netty-shaded:1.20.0 (compile)</li>
          <li>io.grpc:grpc-alts:1.20.0 (compile) / io.grpc:grpc-netty-shaded:1.20.0 (compile)</li>
    </ul>

With Java 8, the relevant dashboard section now reads:

  <h3>io.grpc:grpc-netty-shaded:1.20.0</h3>
  <p class="jar-linkage-report">
    4 target classes
    causing linkage errors referenced from
    4 source classes.
  </p>
      <p class="jar-linkage-report-cause">Class org.conscrypt.AllocatedBuffer is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
      <p class="jar-linkage-report-cause">Class org.conscrypt.Conscrypt is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
      <p class="jar-linkage-report-cause">Class org.conscrypt.HandshakeListener is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
      <p class="jar-linkage-report-cause">Class org.conscrypt.BufferAllocator is not found, referenced from io.grpc.netty.shaded.io.netty.handler.ssl.ConscryptAlpnSslEngine</p>
  <p class="linkage-check-dependency-paths">
    The following paths contain io.grpc:grpc-netty-shaded:1.20.0:
  </p>

    <!-- The visibility of this list is toggled via the button above. Hidden by default -->
    <ul class="linkage-check-dependency-paths"
        style="display:">
          <li>io.grpc:grpc-netty-shaded:1.20.0 (compile)</li>
          <li>io.grpc:grpc-alts:1.20.0 (compile) / io.grpc:grpc-netty-shaded:1.20.0 (compile)</li>
    </ul>

@burkedavison
Copy link
Member Author

burkedavison commented Nov 9, 2023

[INFO] Building: bom-project-using-spring-repository/pom.xml
[INFO] run post-build script verify.groovy
[INFO]   Assertion Error
[INFO]           bom-project-using-spring-repository/pom.xml ...... FAILED (15.8 s)

Replicating locally and saving build.log shows: go/bit/burkedavison/6345083555151872

@burkedavison
Copy link
Member Author

burkedavison commented Nov 9, 2023

LinkageCheckerMainIntegrationTest.testBom_java11 is currently ignored, with the following as the linkageProblems, but no known way to replicate the prior (expected) set:
go/bit/burkedavison/6385103120891904

@burkedavison burkedavison changed the title chore: fake update chore: update linkage tests Nov 10, 2023
@burkedavison burkedavison requested a review from a team November 10, 2023 18:15
@burkedavison burkedavison marked this pull request as ready for review November 10, 2023 18:15
@burkedavison burkedavison merged commit 02c26c9 into GoogleCloudPlatform:master Nov 10, 2023
@burkedavison burkedavison deleted the fake-change branch November 10, 2023 19:15
burkedavison added a commit to burkedavison/cloud-opensource-java that referenced this pull request Nov 10, 2023
burkedavison added a commit to burkedavison/cloud-opensource-java that referenced this pull request Nov 10, 2023
* chore: fake update

* chore: @ignore LinkageCheckerMainIntegrationTest.testBom_java11

* chore: change expected linkage errors in grpc-netty-shaded from 4 to 5

* chore: change expected Linkage Checker rule errors in bom-project-using-spring-repository from 107 to 108

* chore: relocate linkage error assertion to JDK-version specific test

* chore: update LinkageCheckerMainIntegrationTest expected error count

* chore: remove unused import

* chore: remove outdated comments

(cherry picked from commit 02c26c9)
burkedavison added a commit that referenced this pull request Nov 10, 2023
* deps: bigtable 2.25.3 and bigtable-hbase-beam 2.9.2

* chore: update linkage tests (#2358)

* chore: fake update

* chore: @ignore LinkageCheckerMainIntegrationTest.testBom_java11

* chore: change expected linkage errors in grpc-netty-shaded from 4 to 5

* chore: change expected Linkage Checker rule errors in bom-project-using-spring-repository from 107 to 108

* chore: relocate linkage error assertion to JDK-version specific test

* chore: update LinkageCheckerMainIntegrationTest expected error count

* chore: remove unused import

* chore: remove outdated comments

(cherry picked from commit 02c26c9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants