fix: add module-info to be ignored in unique classes test. #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test failure by ignoring
module-infoin unique class check.see failed test here
this test is trying to ensure there is no duplicate class names in classpath. We encountered error where "META-INF.versions.9.module-info.class" exists in multiple artifacts.
This is a descriptive file part of Java Modules ( java >9), and thus duplicate by name in different artifacts is expected.
Why do we started to observe this error now?
I compared error_prone_annotations:2.26.1 vs 2.23.0 (brought in by google-cloud-core before the version update in pr), v2.23.0 does not contain this file.
test case:
see ci result for 028ea64, this commit brings in version updates same as in the original failed test above. It's passing after this fix.