Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade enforcer rule to the latest 3.5.0 #2379

Merged
merged 7 commits into from
Sep 23, 2024

Conversation

suztomo
Copy link
Contributor

@suztomo suztomo commented Sep 13, 2024

Fixes #2378

Release note of the Maven enforcer rules: https://github.com/apache/maven-enforcer/releases

Based on the proposed changes by Robert Scholte in #2378 (comment)

@suztomo suztomo changed the title deps: upgrade enforcer rule to the latest 3.5.0 [work in progress] deps: upgrade enforcer rule to the latest 3.5.0 Sep 13, 2024
@suztomo
Copy link
Contributor Author

suztomo commented Sep 13, 2024

TODO: Move to javax.inject from EnforcerRuleHelper in LinkageCheckerRuleTest.

Based on the proposed changes by Robert Scholte in
GoogleCloudPlatform#2378 (comment)
@suztomo
Copy link
Contributor Author

suztomo commented Sep 17, 2024

~/cloud-opensource-java$ mvn integration-test -Dmaven.test.skip -pl enforcer-rules is failing https://github.com/GoogleCloudPlatform/cloud-opensource-java/actions/runs/10855347076/job/30127764204?pr=2379.

@suztomo suztomo changed the title [work in progress] deps: upgrade enforcer rule to the latest 3.5.0 deps: upgrade enforcer rule to the latest 3.5.0 Sep 23, 2024
@suztomo suztomo marked this pull request as ready for review September 23, 2024 14:18
@suztomo
Copy link
Contributor Author

suztomo commented Sep 23, 2024

All checks have passed.

Copy link

@JoeWang1127 JoeWang1127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@suztomo suztomo merged commit 7c7fe4f into GoogleCloudPlatform:master Sep 23, 2024
3 checks passed
@suztomo suztomo deleted the enforcer_rule_upgrade branch September 23, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enforce-linkage-checker not compatible anymore with recent maven-enforcer-plugin
2 participants