Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "buildpacks" field in app.json #3

Open
ahmetb opened this issue May 14, 2019 · 5 comments
Open

Add support for "buildpacks" field in app.json #3

ahmetb opened this issue May 14, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@ahmetb
Copy link
Contributor

ahmetb commented May 14, 2019

No description provided.

@ahmetb ahmetb changed the title Add support for "buildpacks" field Add support for "buildpacks" field in app.json May 14, 2019
@ahmetb
Copy link
Contributor Author

ahmetb commented May 28, 2019

@jamesward I feel like we should just assume --builder=heroku/buildpacks, and then have an optional array for --buildpack, so we call the CLI like:

pack build --builder=heroku/buildpacks [--buildpack=foo --buildpack=bar ...]

wdyt?

@jamesward
Copy link
Contributor

Sounds great to me but we do need to push to get a Cloud Run bug fixed where most buildpack built images do not currently work (Node & Python are currently broken).

@ahmetb
Copy link
Contributor Author

ahmetb commented May 29, 2019

Yes learned it the hard way yesterday.
The whole project does not seem stable or ready for prime-time. I won’t be touching this anytime soon.

@jamesward
Copy link
Contributor

It’s actually a bug in Cloud Run, because the containers work fine in docket.

@jamesward
Copy link
Contributor

There is a way to specify specific buildpacks via a project.toml file in the root:
buildpacks/pack#421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants