-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buildpack support #43
Comments
Were you thinking this would be done via Cloud Build or just by invoking pack locally? |
Pack locally. It should be easy to vendor in the binary to the container. |
Good deal. We will need to wait for buildpacks/pack#209 to be resolved in a release if we want to use an official released version. Otherwise we'll also have to include |
The docker daemon is accessible on Cloud Shell. Right now the button runs docker and it works great. I’ve also tried pack in Cloud Shell and it works great. |
Ah perfect! |
Can we do the fallback ONLY if Procfile exists? I don’t wanna error out saying “pack failed” because pack is 5% of the use case or less. I mostly want to say “build failed; no Dockerfile or Procfile” instead. |
This implies you have to have a procfile for it to use buildpacks. This isn't really necessary as the buildpacks can create procfile for you. |
This CL uses the heroku/buildpacks builder if a Dockerfile is not found. fixes #43
If there is no Dockerfile, fallback to trying buildpacks. See #3 for an add-on / related discussion.
The text was updated successfully, but these errors were encountered: