Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buildpack support #43

Closed
jamesward opened this issue Jun 17, 2019 · 7 comments · Fixed by #44
Closed

Add buildpack support #43

jamesward opened this issue Jun 17, 2019 · 7 comments · Fixed by #44

Comments

@jamesward
Copy link
Contributor

If there is no Dockerfile, fallback to trying buildpacks. See #3 for an add-on / related discussion.

@poy
Copy link
Contributor

poy commented Jun 18, 2019

Were you thinking this would be done via Cloud Build or just by invoking pack locally?

@jamesward
Copy link
Contributor Author

Pack locally. It should be easy to vendor in the binary to the container.

@poy
Copy link
Contributor

poy commented Jun 18, 2019

Good deal. We will need to wait for buildpacks/pack#209 to be resolved in a release if we want to use an official released version. Otherwise we'll also have to include docker in the image.

@jamesward
Copy link
Contributor Author

The docker daemon is accessible on Cloud Shell. Right now the button runs docker and it works great. I’ve also tried pack in Cloud Shell and it works great.

@poy
Copy link
Contributor

poy commented Jun 18, 2019

Ah perfect!

@ahmetb
Copy link
Contributor

ahmetb commented Jun 18, 2019

Can we do the fallback ONLY if Procfile exists?

I don’t wanna error out saying “pack failed” because pack is 5% of the use case or less. I mostly want to say “build failed; no Dockerfile or Procfile” instead.

@poy
Copy link
Contributor

poy commented Jun 18, 2019

This implies you have to have a procfile for it to use buildpacks. This isn't really necessary as the buildpacks can create procfile for you.

jamesward pushed a commit that referenced this issue Jul 16, 2019
This CL uses the heroku/buildpacks builder if a Dockerfile is not found.

fixes #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants