chore: Generate the cjs and mjs system tests from the ts system test #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hessjcg
changed the title
hessjcg
force-pushed
the
system-test-ts-only
branch
2 times, most recently
from
ab647d1 to
2288c6a
Compare
hessjcg
force-pushed
the
system-test-ts-only
branch
from
2288c6a to
448b385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the system tests are only written in TypeScript. There is a very small wrapper to run the tests
using TS, CJS, and MJS module systems. Previously, we had to write a system test 3 times, one for each
module system.
The same tests are now in new TS files:
system-test/mysql2-connect.*are now inmysql-tests.tssystem-test/pg-connect.*are now inpg-tests.tssystem-test/tedious-connect.*are now intedious-tests.tsThe test "main" files are hand written for TS, MJS, and CJS:
system-test/system.tssystem-test/system.cjssystem-test/system.mjsAdditional small changes were made to the package.json and other supporting scripts.