Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: check all connections for io.EOF #1329

Merged
merged 3 commits into from
Aug 30, 2022
Merged

chore: check all connections for io.EOF #1329

merged 3 commits into from
Aug 30, 2022

Conversation

enocom
Copy link
Member

@enocom enocom commented Aug 25, 2022 •
edited
Loading

This commit updates a test to check all connections for an io.EOF error.

Fixes #1309.

@enocom enocom requested a review from a team August 25, 2022 17:56
@enocom enocom added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 26, 2022
@enocom
Copy link
Member Author

enocom commented Aug 26, 2022 •
edited
Loading

This is the wrong approach. I'll update it now that I understand the actual problem. I've updated this PR to use a correct assertion.

@enocom enocom removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2022
@enocom enocom changed the title chore: add read deadline chore: check all connections for io.EOF Aug 27, 2022
@enocom enocom changed the base branch from v2 to main August 29, 2022 19:17
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

hessjcg
hessjcg reviewed Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hessjcg
hessjcg approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enocom enocom merged commit f7cf969 into main Aug 30, 2022
@enocom enocom deleted the fix-close-test branch August 30, 2022 20:06
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request Sep 13, 2022
@enocom
chore: check all connections for io.EOF
7daf470 
This is a port of GoogleCloudPlatform/cloud-sql-proxy#1329.

Fixes #117.
@enocom enocom mentioned this pull request Sep 13, 2022
Merged
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request Sep 14, 2022
@enocom
chore: check all connections for io.EOF (#129)
1a3d46b 
This is a port of GoogleCloudPlatform/cloud-sql-proxy#1329.

Fixes #117.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carrotman42 Carrotman42 Carrotman42 left review comments

@hessjcg hessjcg hessjcg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2/internal/proxy: TestClientLimitsMaxConnections failed
3 participants
@enocom @Carrotman42 @hessjcg