feat: add support for FUSE connections #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also ensures that closing the proxy.Client blocks until all listeners are closed.
kurtisvg
approved these changes
Sep 7, 2022
| var ( | ||
| // Instance connection name is the format <PROJECT>:<REGION>:<INSTANCE> | ||
| // Additionally, we have to support legacy "domain-scoped" projects (e.g. "google.com:PROJECT") | ||
| connNameRegex = regexp.MustCompile("([^:]+(:[^:]+)?):([^:]+):([^:]+)") |
There was a problem hiding this comment.
Should we consider just exposing these from the Go connector?
enocom
added a commit
that referenced
this pull request
Sep 7, 2022
This commit also ensures that closing the proxy.Client blocks until all listeners are closed.
enocom
added a commit
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also ensures that closing the proxy.Client blocks until all
listeners are closed.