Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug partitions to examples #117

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

nick-stroud
Copy link
Collaborator

@nick-stroud nick-stroud commented Feb 16, 2022

Submission Checklist:

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change? - NA
  • Is unit test coverage still above 80%? - NA
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the examples Readme.md to describe the two partitions, making sure it is clear that any performance analysis should be done on compute. Also, please describe a little which quota people should request as our users won't know. (C2s, placement groups, ...)

@nick-stroud nick-stroud force-pushed the debug_examples branch 4 times, most recently from de0433b to b51d496 Compare February 16, 2022 22:39
@nick-stroud nick-stroud changed the title Debug examples Add debug partitions to examples Feb 16, 2022
@nick-stroud nick-stroud marked this pull request as ready for review February 16, 2022 22:43
@nick-stroud
Copy link
Collaborator Author

nick-stroud commented Feb 16, 2022

Passed integration tests on previous commit (before adding docs). cloud build

Working on specific quota guidance in follow on cl. example

@nick-stroud nick-stroud requested a review from cboneti February 16, 2022 22:47
@nick-stroud nick-stroud marked this pull request as draft February 17, 2022 01:59
Copy link
Collaborator Author

@nick-stroud nick-stroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted - still figuring out GitHub.

@nick-stroud nick-stroud marked this pull request as ready for review February 18, 2022 00:31
@cboneti cboneti merged commit 6d2892a into GoogleCloudPlatform:develop Feb 18, 2022
@nick-stroud nick-stroud deleted the debug_examples branch February 18, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants