-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spack example #120
Add Spack example #120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor comments
b0cfc5f
to
aca92bc
Compare
Adds a spack specific example that creates a build VM for Spack that shuts down on completion. Includes a workstation VM for testing and verifying the spack installation. Also made minor updates to the other examples.
Different environments and versions of python require different package names for pip3 (pip3/python3-pip), so here I check if python3-pip exists and default to pip3 otherwise.
I ran into an issue with the I'm still investigating why this is happening. This example works using filestore, but before I merge this, I want to verify the problem was with nfs-server or elsewhere and not spack-install. |
I've not been able to replicate the bug from yesterday. I'm guessing it was some issue with my environment that I'll continue to monitor, but this PR should be ready to be re-reviewed now. |
From the spack point of view, I think this LGTM. :) |
Address reviewer feedback, primarily moving dependency install for spack to a new ansible script, installed separately. This preserves a low dependency installation for spack independently. Also addressed in this commit: * Update examples documentation to match syle * Move terraform backend comments to examples README.md to avoid duplicated code.
- name: Install google cloud storage | ||
pip: | ||
name: google-cloud-storage | ||
executable: pip3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much prettier! 😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heyealex and I talked about this offline, but something that feels fragile to me is having the dependencies outside of the install-spack resource. This allows users to select the install-spack resource, but not the dependencies, which would cause the install-spack resource to fail in a non-obvious way.
However, there are other features that are going to be developed within the toolkit eventually that will make this easier to deal with. So I'll approve this for now with the assumption that it might be reworked in the future.
Adds a spack specific example that creates a build VM for Spack that
shuts down on completion. Includes a workstation VM for testing and
verifying the spack installation.
Also made minor updates to the other examples.
Submission Checklist:
pre-commit install
make tests
change?
guides?