Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spack example #120

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Conversation

heyealex
Copy link
Contributor

Adds a spack specific example that creates a build VM for Spack that
shuts down on completion. Includes a workstation VM for testing and
verifying the spack installation.

Also made minor updates to the other examples.

Submission Checklist:

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments

examples/spack-build.yaml Outdated Show resolved Hide resolved
examples/spack-build.yaml Outdated Show resolved Hide resolved
examples/spack-build.yaml Outdated Show resolved Hide resolved
@heyealex heyealex force-pushed the spack-example branch 2 times, most recently from b0cfc5f to aca92bc Compare March 3, 2022 01:07
heyealex added 2 commits March 3, 2022 01:10
Adds a spack specific example that creates a build VM for Spack that
shuts down on completion. Includes a workstation VM for testing and
verifying the spack installation.

Also made minor updates to the other examples.
Different environments and versions of python require different package
names for pip3 (pip3/python3-pip), so here I check if python3-pip exists
and default to pip3 otherwise.
@heyealex
Copy link
Contributor Author

heyealex commented Mar 3, 2022

I ran into an issue with the nfs-server while testing where the spack directory under /apps would be created before the spack builder could get to it.

I'm still investigating why this is happening. This example works using filestore, but before I merge this, I want to verify the problem was with nfs-server or elsewhere and not spack-install.

@heyealex
Copy link
Contributor Author

heyealex commented Mar 3, 2022

I've not been able to replicate the bug from yesterday. I'm guessing it was some issue with my environment that I'll continue to monitor, but this PR should be ready to be re-reviewed now.

examples/README.md Outdated Show resolved Hide resolved
examples/hpc-cluster-high-io.yaml Outdated Show resolved Hide resolved
@douglasjacobsen
Copy link
Collaborator

From the spack point of view, I think this LGTM. :)

douglasjacobsen
douglasjacobsen previously approved these changes Mar 4, 2022
Address reviewer feedback, primarily moving dependency install for spack
to a new ansible script, installed separately. This preserves a low
dependency installation for spack independently.

Also addressed in this commit:
* Update examples documentation to match syle
* Move terraform backend comments to examples README.md to avoid
  duplicated code.
- name: Install google cloud storage
pip:
name: google-cloud-storage
executable: pip3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much prettier! 😍

Copy link
Collaborator

@douglasjacobsen douglasjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heyealex and I talked about this offline, but something that feels fragile to me is having the dependencies outside of the install-spack resource. This allows users to select the install-spack resource, but not the dependencies, which would cause the install-spack resource to fail in a non-obvious way.

However, there are other features that are going to be developed within the toolkit eventually that will make this easier to deal with. So I'll approve this for now with the assumption that it might be reworked in the future.

@heyealex heyealex merged commit 057011d into GoogleCloudPlatform:develop Mar 4, 2022
@heyealex heyealex deleted the spack-example branch March 4, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants