Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify G2 family as having accelerators #1415

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Identify G2 family as having accelerators #1415

merged 1 commit into from
Jun 6, 2023

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Jun 6, 2023

Instances with accelerators attached do not support live migration. This commit updates section of code to automatically disable live migration on behalf of the user when G2 VMs are selected.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes
Identify G2 family as having accelerators
3c20bd4 
Instances with accelerators attached do not support live migration. This
commit updates section of code to automatically disable live migration
on behalf of the user when G2 VMs are selected.
@tpdownes tpdownes requested a review from rohitramu June 6, 2023 15:40
@rohitramu rohitramu assigned tpdownes and unassigned rohitramu Jun 6, 2023
rohitramu
rohitramu approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@rohitramu rohitramu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No pressure to make those changes, but thought I'd suggest them as a potential improvement.

community/modules/compute/gke-node-pool/main.tf Show resolved Hide resolved
modules/compute/vm-instance/main.tf Show resolved Hide resolved
modules/packer/custom-image/image.pkr.hcl Show resolved Hide resolved
modules/scheduler/batch-job-template/main.tf Show resolved Hide resolved
tools/validate_configs/golden_copies/expectations/igc_pkr/one/image/image.pkr.hcl Show resolved Hide resolved
tools/validate_configs/golden_copies/expectations/text_escape/zero/lime/image.pkr.hcl Show resolved Hide resolved
@tpdownes tpdownes merged commit bd38e22 into GoogleCloudPlatform:develop Jun 6, 2023
@tpdownes tpdownes deleted the add_g2_family branch June 6, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitramu rohitramu rohitramu approved these changes

Assignees

@tpdownes tpdownes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpdownes @rohitramu