Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make execute command ansible script generic so it can be reused #1487

Conversation

nick-stroud
Copy link
Collaborator

This change is a no-op. This script will be reused by spack-execute module.

Note the target branch. Since there are several breaking changes associated with Spack redesign I would like the user to only see a single change. Development will happen on a feature branch.

As this change is a no-op it could be merged to develop but I think it will make the history easier to track to keep it all on the feature branch.

Tested manually.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes assigned nick-stroud and unassigned tpdownes Jun 21, 2023
@nick-stroud nick-stroud merged commit 05098b2 into GoogleCloudPlatform:spack-redesign Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants