Add functionality for Spack module to take data runners #1496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data_files
are a subset ofstartup-script.runners
. They can only be of type data and must have a destination of an absolute path. While this same functionality could be achieved by using startup script directly, it was decided that it would be logically cleaner to define all of the spack configs in a single module.It was decided to not duplicate the validation that startup script does. This leaves some minor naming mismatch in error messages as validation will report that "runner cannot do such and such" instead of "data_files".
Tested manually: Upload file via data runner and then cat the file in commands
Submission Checklist
Please take the following actions before submitting this pull request.