Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split spack functionality into setup and execute modules #1583

Merged

Conversation

nick-stroud
Copy link
Collaborator

@nick-stroud nick-stroud commented Jul 13, 2023

This change:

  • Moves functionality into spack-execute module
  • Adds use of bucket & startup script to store spack scripts

Tested manually:

  • Actual gromacs install from cache
  • Adding data files
  • Chaining execute modules

Future changes:

  • Rename spack install
  • Migrate examples
  • Clean up spack install outputs
  • update documentation

Notes on review:

  • Ignore readmes (only automated changes)
  • Note that most of code is just moving
  • Review commits independently

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor change requests.

community/modules/scripts/spack-execute/main.tf Outdated Show resolved Hide resolved
community/modules/scripts/spack-execute/versions.tf Outdated Show resolved Hide resolved
@tpdownes tpdownes assigned nick-stroud and unassigned tpdownes Jul 14, 2023
@nick-stroud nick-stroud enabled auto-merge July 14, 2023 20:27
@nick-stroud nick-stroud merged commit 7618883 into GoogleCloudPlatform:spack-redesign Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants