Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spack module tweeks to make compatible across supported images #1645

Conversation

nick-stroud
Copy link
Collaborator

The Spack modules were tested across the following operating systems:

      instance_image:
        family: hpc-centos-7
        project: cloud-hpc-image-public

      instance_image:
        family: hpc-rocky-linux-8
        project: cloud-hpc-image-public

      instance_image:
        family: debian-11
        project: debian-cloud

      instance_image:
        family: ubuntu-2004-lts
        project: ubuntu-os-cloud

Fixes in this change:

  • source is not available in default shell for Ubuntu and Debian
  • Explicitly call bash for command execution to maintain bash pipefail option
  • python package is not defined for rocky.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes assigned nick-stroud and unassigned tpdownes Aug 2, 2023
@nick-stroud nick-stroud merged commit 9d68a15 into GoogleCloudPlatform:spack-redesign Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants