Release v1.23.0 #1762
Merged
Release v1.23.0 #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Shakeeb Shams <shakeebshams@gmail.com>
Removed double blank lines.
Fixed SSH issues.
…and set up the environment variables correctly. Still under test. Last test broke the start of the code editor, so now the hpc clone and update is run in the background.
…r on so users should have it if they start their workstation before the full build is complete.
… running through entire creation of the workstation. The only step left at the end would be to go to the Workstation page, start the workstation, and launch.
Additional change to Dockerfile to change source of scripts back to GCP repository.
- Use local hpc toolkit files for building docker instead of those hosted on github to remove dependency different branches/forks. - Removed shellcheck from apt-get now donwload directly from the repo with a specified version.
Bump slurm-gcp to 5.7.6 (from 5.7.5)
Add check for invalid module id
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.134.0 to 0.136.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.134.0...v0.136.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…es/develop/google.golang.org/api-0.136.0 Bump google.golang.org/api from 0.134.0 to 0.136.0
There is a reference setting suggestion set of code for future reference, but it will be removed for the PR. Cleaned up unused code and limited suggestions to module names. Cleaned up the closestreference function and error creation. Moved some of the error to a new HintError type Updated to use levenshtein library instead of our function.
…ts to module verification, and updates setting references.
Fix broken link for compatibility matrix in Filestore documentation
Updates to workstation build scripts to add new code-oss extensions
Closes stale issues
```
...blueprint...
validators:
- validator: test_resource_requirements
inputs:
ignore_usage: false
requirements:
- metric: "compute.googleapis.com/disks_total_storage"
service: "compute.googleapis.com"
consumer: "projects/X"
required: 900000
dimensions: { "region": "us-central1" }
aggregation: "SUM"
```
```
validator "test_resource_requirements" failed:
not sufficient limit for resource "compute.googleapis.com/disks_total_storage", limit=4096 < requested=900000
not sufficient limit for resource "compute.googleapis.com/disks_total_storage" in map[region:us-central1], limit=102400 < requested=900000 + usage=756
One or more blueprint validators has failed ...
```
* Fill in default values for quota validation inputs;
* Fix false-positive "test_deployment_variable_not_used";
* Add `Blueprint.ProjectID` method.
```
vars:
project_id: X
deployment_name: tst
region: europe-west1
num_nodes: 9
...
validators:
- validator: test_resource_requirements
inputs:
requirements:
- metric: compute.googleapis.com/disks_total_storage
required: ((var.num_nodes * 100000))
```
```
validator "test_resource_requirements" failed:
not enough quota for resource "compute.googleapis.com/disks_total_storage", limit=4096 < requested=900000
not enough quota for resource "compute.googleapis.com/disks_total_storage" in map[region:europe-west1], limit=102400 < requested=900000 + usage=256
One or more blueprint validators has failed...
```
Fix label for dependabot go updates (release-chore)
- print sinfo after Slurm partition test - decrease the n2 node wait time to 300s
Improvements to hpc-enterprise blueprint
Add a blueprint that is compatible with Qwiklabs tutorials
Update ml-slurm base image
Update release-candidate with release v1.22.1
Update reference version to v1.23.0
harshthakkar01
requested review from
mr0re1,
tpdownes,
heyealex and
nick-stroud
|
/gcbrun |
tpdownes
approved these changes
Sep 18, 2023
mr0re1
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Please take the following actions before submitting this pull request.