-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCLS Integration Test #1810
Merged
cdunbar13
merged 5 commits into
GoogleCloudPlatform:develop
from
cdunbar13:hcls-integration-test
Oct 5, 2023
Merged
HCLS Integration Test #1810
cdunbar13
merged 5 commits into
GoogleCloudPlatform:develop
from
cdunbar13:hcls-integration-test
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd45006
to
546549c
Compare
nick-stroud
reviewed
Oct 3, 2023
tools/cloud-build/daily-tests/ansible_playbooks/tasks/rescue_ghpc_failure.yml
Show resolved
Hide resolved
…ut allows for multigroup destroy
nick-stroud
requested changes
Oct 4, 2023
tools/cloud-build/daily-tests/ansible_playbooks/slurm-integration-test.yml
Show resolved
Hide resolved
tools/cloud-build/daily-tests/ansible_playbooks/slurm-integration-test.yml
Show resolved
Hide resolved
tools/cloud-build/daily-tests/ansible_playbooks/tasks/rescue_ghpc_failure.yml
Show resolved
Hide resolved
tools/cloud-build/daily-tests/ansible_playbooks/tasks/rescue_ghpc_failure.yml
Outdated
Show resolved
Hide resolved
I am fine to merge over the current failing tests (batch-mpi: known unrelated failure, and centos7: capacity), but please see comments. |
nick-stroud
requested changes
Oct 4, 2023
tools/cloud-build/daily-tests/ansible_playbooks/slurm-integration-test.yml
Show resolved
Hide resolved
tools/cloud-build/daily-tests/ansible_playbooks/tasks/rescue_ghpc_failure.yml
Show resolved
Hide resolved
tools/cloud-build/daily-tests/ansible_playbooks/tasks/rescue_ghpc_failure.yml
Outdated
Show resolved
Hide resolved
tools/cloud-build/daily-tests/ansible_playbooks/tasks/rescue_ghpc_failure.yml
Show resolved
Hide resolved
8e928c2
to
e1b9cd3
Compare
nick-stroud
approved these changes
Oct 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial test for HCLS. Creates cluster, runs some basic mount and partitions tests.
Had to make updates to slurm-integration-test so it would run multigroup deployments. It should still be compatible with the other integration tests since it just goes from terraform commands to ghpc.
Added a login IP check because without
disable_login_public_ips: false
the integration test can fail without triggering the rescue or the always block in the integration test section (no hosts so it skips the integration tests without running always).