Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCLS Integration Test #1810

Merged

Conversation

cdunbar13
Copy link
Contributor

Initial test for HCLS. Creates cluster, runs some basic mount and partitions tests.

Had to make updates to slurm-integration-test so it would run multigroup deployments. It should still be compatible with the other integration tests since it just goes from terraform commands to ghpc.

Added a login IP check because without disable_login_public_ips: false the integration test can fail without triggering the rescue or the always block in the integration test section (no hosts so it skips the integration tests without running always).

@cdunbar13 cdunbar13 added the release-improvements Added to release notes under the "Improvements" heading. label Oct 3, 2023
@cdunbar13 cdunbar13 requested a review from nick-stroud October 3, 2023 15:00
@cdunbar13 cdunbar13 force-pushed the hcls-integration-test branch from cd45006 to 546549c Compare October 3, 2023 15:40
@nick-stroud nick-stroud assigned cdunbar13 and unassigned nick-stroud Oct 3, 2023
@cdunbar13 cdunbar13 assigned nick-stroud and unassigned cdunbar13 Oct 4, 2023
@cdunbar13 cdunbar13 requested a review from nick-stroud October 4, 2023 15:04
@nick-stroud nick-stroud assigned cdunbar13 and unassigned nick-stroud Oct 4, 2023
@nick-stroud
Copy link
Collaborator

I am fine to merge over the current failing tests (batch-mpi: known unrelated failure, and centos7: capacity), but please see comments.

@cdunbar13 cdunbar13 requested a review from nick-stroud October 4, 2023 18:59
@cdunbar13 cdunbar13 removed their assignment Oct 4, 2023
@nick-stroud nick-stroud assigned cdunbar13 and unassigned nick-stroud Oct 4, 2023
@cdunbar13 cdunbar13 force-pushed the hcls-integration-test branch from 8e928c2 to e1b9cd3 Compare October 4, 2023 20:50
@cdunbar13 cdunbar13 assigned nick-stroud and unassigned cdunbar13 Oct 4, 2023
@nick-stroud nick-stroud assigned cdunbar13 and unassigned nick-stroud Oct 4, 2023
@cdunbar13 cdunbar13 merged commit d784e11 into GoogleCloudPlatform:develop Oct 5, 2023
@cdunbar13 cdunbar13 deleted the hcls-integration-test branch October 5, 2023 17:11
@cboneti cboneti mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants