Tutorial for FSI VaR MonteCarlo #1874
Conversation
jrossthomson
changed the title
|
I don't see that I can add a label. I assume that is on purpose. Thanks! |
nick-stroud
added
the
release-new-modules
There was a problem hiding this comment.
I am going to piggy pack with the discussion that you are having with @cboneti. I think there are several more structural concerns that I have that would be best to have discussion about. Consider waiting to address my comments here until we have had that discussion.
|
/gcbrun |
community/modules/files/fsi-montecarlo-on-batch/FSI_MonteCarlo.ipynb
Outdated
Show resolved
Hide resolved
|
/gcbrun |
|
/gcbrun |
|
@jrossthomson I went ahead and addressed the majority of my findings. Please review 1533b71 and make sure you agree with my changes. Generally I tracked these in comments if you want more context. I also needed to incorporate updates from develop to get tests to pass. I did not want to force push over your history so I manually merged in the latest copy of develop. There are still a few open items for you to address. Feel free to reach out to discuss. |
nick-stroud
merged commit 8f1a75a
into
GoogleCloudPlatform:develop
Adds
docs/tutorials/fsi-montecarlo-on-batch/README.md: Demo used for SC23.Several modules are added to support this demo. While we hope these modules are able to be reused and repurposed, they are marked as experimental and their main purpose is to support this demo.
New modules: