Slurm6. Fix race condition between GCS config files and instances #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr0re1
added
the
release-module-improvements
mr0re1
requested review from
cboneti and
nick-stroud
and removed request for
harshthakkar01
nick-stroud
approved these changes
Nov 9, 2023
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/slurm_files.tf
Show resolved
Hide resolved
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/slurm_files.tf
Show resolved
Hide resolved
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/controller.tf
Outdated
Show resolved
Hide resolved
There was a race between config files stored in GCS and instance using those files. Fixed by stopping using SchedMD `slurm_cluster` module, instead replicate (unwrap) its content within Toolkit's `schedmd-slurm-gcp-v6-controller` module. This let us to establish proper `depends_on = [slurm_files]` for controller instance resource. **NOTE:** This changes made us to temporary remove support for using CloudSQL as DB backend since it was a point of circular dependencies with updated `depends_on`. To be adressed later. Added Filestore usage to the `community/examples/hpc-slurm6.yaml` as it should work after the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a race between config files stored in GCS and instance using those files. Fixed by stopping using SchedMD
slurm_clustermodule, instead replicate (unwrap) its content within Toolkit'sschedmd-slurm-gcp-v6-controllermodule. This let us to establish properdepends_on = [slurm_files]for controller instance resource.NOTE: This changes made us to temporary remove support for using CloudSQL as DB backend since it was a point of circular dependencies with updated
depends_on. To be adressed later.Added Filestore usage to the
community/examples/hpc-slurm6.yamlas it should work after the fix.