Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TFLint to 0.49 & latest plugin in precommit #2041

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

fustic
Copy link
Contributor

@fustic fustic commented Dec 11, 2023

This change fixes the unused variable warning so that validation blocks are not counted as a use of the input variables. i.e. it eliminate false negatives.

TFLint 0.49.0 includes a bundled generic ruleset (v0.5.0) for the terraform language itself. v0.5.0 includes a change made in response to an issue.

TFLINT_VERSION is updated to v0.49.0
version of terraform plugin is updated to 0.5.0
all warnings are decorated by # tflint-ignore: terraform_unused_declarations

a local run is passing:

➜  hpc-toolkit git:(tflint-update) ✗ pre-commit run -a terraform_tflint
Terraform validate with tflint...........................................Passed

as well as make tests

@tpdownes tpdownes self-requested a review December 11, 2023 15:23
@tpdownes tpdownes self-assigned this Dec 11, 2023
@tpdownes tpdownes added the release-chore To not include into release notes label Dec 11, 2023
@tpdownes
Copy link
Member

/gcbrun

Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution!

@tpdownes tpdownes merged commit c7f10ca into GoogleCloudPlatform:develop Dec 11, 2023
6 of 36 checks passed
@nick-stroud nick-stroud mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants