Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support explicit reserved_ip_range for Filestore instances #2072

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Support explicit reserved_ip_range for Filestore instances #2072

merged 1 commit into from
Dec 27, 2023

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Dec 26, 2023 •
edited
Loading

This PR allows a user to set an explicit IP range in which to create Filestore instances by direct peering. The default remains automatic selection. Tested with:

  - id: homefs
    source: modules/file-system/filestore
    use:
    - sysnet
    settings:
      filestore_tier: HIGH_SCALE_SSD
      size_gb: 10240
      local_mount: /home
      reserved_ip_range: 192.168.0.0/26

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes requested a review from rohitramu December 26, 2023 23:58
@tpdownes tpdownes added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Dec 27, 2023
@tpdownes tpdownes force-pushed the filestore_reserved_ip_range branch from 046b4a8 to b7accb0 Compare December 27, 2023 00:06
@rohitramu rohitramu assigned tpdownes and unassigned rohitramu Dec 27, 2023
@tpdownes tpdownes merged commit e3497c1 into GoogleCloudPlatform:develop Dec 27, 2023
7 of 35 checks passed
@tpdownes tpdownes deleted the filestore_reserved_ip_range branch December 27, 2023 01:04
@nick-stroud nick-stroud mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitramu rohitramu rohitramu approved these changes

Assignees

@tpdownes tpdownes

Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpdownes @rohitramu