Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spack openfoam example to Slurm V6 #2090

Merged

Conversation

harshthakkar01
Copy link
Contributor

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 added the release-improvements Added to release notes under the "Improvements" heading. label Jan 4, 2024
@cboneti cboneti removed the request for review from nick-stroud January 4, 2024 17:24
cboneti
cboneti previously requested changes Jan 4, 2024
Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the documentation:

  1. point to our fork of Slurm-GCP.
  2. the spack cache comment is outdated now, are we using the GCP cache by default? what is the completion time?
  3. Cluster deployment: you changed the deployment name, therefore, you have to change the deployment steps. The connection to the controller will also be affected since the cluster name, with v6, will likely be different. Same goes with the login node.

docs/tutorials/openfoam/spack-openfoam.yaml Show resolved Hide resolved
docs/tutorials/openfoam/spack-openfoam.md Show resolved Hide resolved
docs/tutorials/openfoam/spack-openfoam.yaml Outdated Show resolved Hide resolved
@harshthakkar01 harshthakkar01 merged commit 10c8568 into GoogleCloudPlatform:develop Jan 8, 2024
6 of 35 checks passed
@harshthakkar01 harshthakkar01 deleted the spack-issue branch January 8, 2024 19:59
@harshthakkar01 harshthakkar01 added the release-deprecations Added to release notes under the "Deprecations" heading. label Jan 9, 2024
@mr0re1 mr0re1 mentioned this pull request Feb 12, 2024
@nick-stroud nick-stroud mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-deprecations Added to release notes under the "Deprecations" heading. release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants