-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spack openfoam example to Slurm V6 #2090
Merged
harshthakkar01
merged 1 commit into
GoogleCloudPlatform:develop
from
harshthakkar01:spack-issue
Jan 8, 2024
Merged
Update spack openfoam example to Slurm V6 #2090
harshthakkar01
merged 1 commit into
GoogleCloudPlatform:develop
from
harshthakkar01:spack-issue
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ee35cb
to
34cfeca
Compare
cboneti
reviewed
Jan 4, 2024
cboneti
previously requested changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also fix the documentation:
- point to our fork of Slurm-GCP.
- the spack cache comment is outdated now, are we using the GCP cache by default? what is the completion time?
- Cluster deployment: you changed the deployment name, therefore, you have to change the deployment steps. The connection to the controller will also be affected since the cluster name, with v6, will likely be different. Same goes with the login node.
mr0re1
reviewed
Jan 4, 2024
mr0re1
reviewed
Jan 4, 2024
34cfeca
to
1970a31
Compare
mr0re1
reviewed
Jan 5, 2024
mr0re1
reviewed
Jan 5, 2024
mr0re1
approved these changes
Jan 5, 2024
1970a31
to
f1c3636
Compare
jrossthomson
approved these changes
Jan 5, 2024
f1c3636
to
e99d462
Compare
e99d462
to
1b2175f
Compare
mr0re1
approved these changes
Jan 8, 2024
10c8568
into
GoogleCloudPlatform:develop
6 of 35 checks passed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release-deprecations
Added to release notes under the "Deprecations" heading.
release-improvements
Added to release notes under the "Improvements" heading.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Please take the following actions before submitting this pull request.