Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily integration test of Packer example #211

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Add daily integration test of Packer example #211

merged 3 commits into from
Apr 14, 2022

Conversation

tpdownes
Copy link
Member

This does a full run of our simple Packer example:

  • provisions a new network and subnetwork with appropriate firewall rules
  • builds and deletes a VM image

The main area of concern I have is that only 1 of these builds can be executed concurrently because the subnetwork name is static. The intent is to run this only as a daily trigger so I don't think this should be a blocker - eliminating the static nature of the subnetwork name is also planned. In the meantime, it will be a test of the ability of the VPC module to reliably cleanup after itself.

Submission Checklist

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@tpdownes tpdownes requested a review from nick-stroud April 14, 2022 15:08
@tpdownes tpdownes changed the base branch from main to develop April 14, 2022 15:08
@nick-stroud nick-stroud assigned tpdownes and unassigned nick-stroud Apr 14, 2022
@tpdownes tpdownes assigned nick-stroud and unassigned tpdownes Apr 14, 2022
Copy link
Collaborator

@nick-stroud nick-stroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I know @cboneti had some interest in this pr. I will leave it up to you if you want him to take one last look.

@nick-stroud nick-stroud assigned tpdownes and unassigned nick-stroud Apr 14, 2022
@tpdownes tpdownes assigned cboneti and unassigned tpdownes Apr 14, 2022
@tpdownes
Copy link
Member Author

@cboneti for clarity I'd like an approval since you raised some issues here and directly

@cboneti cboneti assigned tpdownes and unassigned cboneti Apr 14, 2022
@tpdownes tpdownes merged commit 9bf4074 into GoogleCloudPlatform:develop Apr 14, 2022
@tpdownes tpdownes deleted the feat_packer_tests branch April 15, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants