Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change batch-job-base template from json to YAML #2199

Merged

Conversation

aaronegolden
Copy link
Contributor

Batch supports YAML job configurations now so we can use YAML everywhere instead of JSON, which will hopefully make some of the conditional syntax in the templates easier to manage.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

Batch supports YAML job configurations now so we can use YAML
everywhere instead of JSON, which will hopefully make some of
the conditional syntax in the templates easier to manage.
@nick-stroud nick-stroud self-assigned this Feb 3, 2024
@nick-stroud
Copy link
Collaborator

nick-stroud commented Feb 5, 2024

/gcbrun
Waiting for batch integration tests.

@nick-stroud nick-stroud added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Feb 5, 2024
@nick-stroud
Copy link
Collaborator

/gcbrun

@nick-stroud nick-stroud merged commit ac413d4 into GoogleCloudPlatform:develop Feb 6, 2024
9 of 32 checks passed
@mr0re1 mr0re1 mentioned this pull request Feb 12, 2024
@nick-stroud nick-stroud mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants