Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slurm-GCP Release 6.4.1 #2230

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Slurm-GCP Release 6.4.1 #2230

merged 4 commits into from
Feb 22, 2024

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Feb 12, 2024 •
edited
Loading

Features from 6.4.1

  • Fix regression in slurmsync that was discovered prior to release; fix ensures that compact placement policies are not accidentally deleted for nodes being provisioned
  • Remove configuration values that are no longer supported by 23.11 (harmless log errors)
  • Use beta GCE API due to potential use of maintenanceInterval setting on VMs

Features from 6.4.0 (unreleased)

  • Expose maintenance_interval in slurm-gcp v6 nodeset module

Features from 6.3.5 (unreleased)

  • Change slurm version to 23.11.3
  • Update cuda to 12.3.2
  • Fix slurmsync error on removing powered up nodes.
  • Fix slurmrestd address in service file

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes added release-version-updates Added to release notes under the "Version Updates" heading. do-not-merge Block merging of this PR labels Feb 12, 2024
@tpdownes tpdownes self-assigned this Feb 12, 2024
@tpdownes tpdownes force-pushed the slurm_gcp_6_4_0 branch 2 times, most recently from 4ce2c74 to fa03931 Compare February 16, 2024 16:41
@tpdownes tpdownes force-pushed the slurm_gcp_6_4_0 branch 6 times, most recently from 60440bc to b6cd840 Compare February 21, 2024 23:40
@tpdownes tpdownes changed the title Slurm-GCP Release 6.4.0 Slurm-GCP Release 6.4.1 Feb 21, 2024
@tpdownes tpdownes removed the do-not-merge Block merging of this PR label Feb 22, 2024
@tpdownes tpdownes marked this pull request as ready for review February 22, 2024 01:43
@tpdownes tpdownes requested a review from mr0re1 February 22, 2024 01:44
@tpdownes
Parameterize Slurm v6 image building example
dec25ba 
By default, honor the Slurm version in the tag.
@tpdownes
Update to Slurm-GCP 6.4.1
e56c284
@tpdownes
Expose maintenance_interval in slurm-gcp v6 nodeset module
4380e87 
Use null as default value in Toolkit wrapper so that the default value
in slurm-gcp module itself is honored.
@tpdownes
Update tags on Slurm TPU integration test
a7e2b19
@cdunbar13 cdunbar13 self-requested a review February 22, 2024 16:48
@tpdownes tpdownes merged commit 3a46dd8 into GoogleCloudPlatform:develop Feb 22, 2024
13 of 36 checks passed
@tpdownes tpdownes deleted the slurm_gcp_6_4_0 branch February 22, 2024 16:51
@alyssa-sm alyssa-sm mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdunbar13 cdunbar13 cdunbar13 approved these changes

@mr0re1 mr0re1 Awaiting requested review from mr0re1

Assignees

@mr0re1 mr0re1

@tpdownes tpdownes

Labels
release-version-updates Added to release notes under the "Version Updates" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpdownes @cdunbar13 @mr0re1