Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in validation of variable in PBS module #2255

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

tpdownes
Copy link
Member

While drafting #2247 this bug was discovered. This commit uses the same solution.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

While drafting GoogleCloudPlatform#2247 this bug was
discovered. This commit uses the same solution.
@tpdownes tpdownes requested a review from mr0re1 February 16, 2024 22:10
@tpdownes tpdownes added the release-bugfix Added to release notes under the "Bug fixes" heading. label Feb 16, 2024
@mr0re1 mr0re1 assigned tpdownes and unassigned mr0re1 Feb 20, 2024
@tpdownes tpdownes merged commit 832cba8 into GoogleCloudPlatform:develop Feb 20, 2024
10 of 35 checks passed
@tpdownes tpdownes deleted the fix_pbs_validation branch February 20, 2024 20:58
@alyssa-sm alyssa-sm mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants