Prevent usage of placement with static and auto-scale nodes in same nodeset #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr0re1
approved these changes
Feb 24, 2024
nick-stroud
added
the
release-module-improvements
nick-stroud
merged commit 7cbbe76
into
GoogleCloudPlatform:develop
9 of 36 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory this could work but currently does not work and is not something we have historically supported. Current behavior is that deployment succeeds but auto-scale nodes are not schedulable.
I have confirmed that mixing static and auto-scale works when placement is off.
Submission Checklist
Please take the following actions before submitting this pull request.