Update slurm-gcp module to use custom endpoints. #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdunbar13
added
the
release-module-improvements
cdunbar13
force-pushed
the
decouple-slurm-update
branch
2 times, most recently
from
b553892 to
2314637
Compare
cdunbar13
changed the title
cdunbar13
force-pushed
the
decouple-slurm-update
branch
from
3df8e5c to
2424e35
Compare
cdunbar13
added
release-key-new-features
cdunbar13
force-pushed
the
decouple-slurm-update
branch
from
2424e35 to
06da506
Compare
mr0re1
reviewed
Jul 1, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/scripts/cleanup_compute.sh
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Jul 1, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/variables.tf
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Jul 1, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/variables.tf
Show resolved
Hide resolved
mr0re1
approved these changes
Jul 1, 2024
cdunbar13
force-pushed
the
decouple-slurm-update
branch
2 times, most recently
from
89a758d to
d144601
Compare
cdunbar13
force-pushed
the
decouple-slurm-update
branch
2 times, most recently
from
49f4aab to
887e5f6
Compare
mr0re1
approved these changes
Jul 8, 2024
cdunbar13
force-pushed
the
decouple-slurm-update
branch
from
be8636c to
f9f04c7
Compare
…r changes in slurm-gcp Also updated cleanup_compute to be compatible with different versions of gcloud Update to use slurm-gcp 6.5.10
cdunbar13
force-pushed
the
decouple-slurm-update
branch
from
f9f04c7 to
445ca5c
Compare
cdunbar13
force-pushed
the
decouple-slurm-update
branch
from
8dd2c02 to
db6aaf1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the process of decoupling ghpc from the GCP prod environment, this PR adds two new variables to the slurm-gcp v6 set of modules. The two values are intended to go into the config.yaml that slurm-gcp creates and allow users to access other API endpoints.
Tested by adding:
To a controller's settings and verified by checking
/slurm/scripts/config.yamlto ensure that the contents were transferred successfully.This PR is waiting for a new release of Slurm-GCP which is required for these changes.