Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validator for Terraform version and SlurmGCP6 #2772

Merged

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Jul 17, 2024

$ make && ./ghpc create tst.yaml -w
**************** building ghpc ************************
validator "test_tf_version_for_slurm" failed:
Error: Using a newer version of Terraform can lead to controller replacement on reconfigure for Slurm GCP v6

Please be advised of this known issue: https://github.com/GoogleCloudPlatform/hpc-toolkit/issues/2774
Until resolved it is advised to use Terraform 1.4.0 with Slurm deployments.

To silence this warning, add flag: --skip-validators=test_tf_version_for_slurm

One or more blueprint validators has failed. See messages above for suggested
actions. General troubleshooting guidance and instructions for configuring
validators are shown below.

- https://goo.gle/hpc-toolkit-troubleshooting
- https://goo.gle/hpc-toolkit-validation

Validators can be silenced or treated as warnings or errors:

- https://goo.gle/hpc-toolkit-validation-levels

validation failed due to the issues listed above
$ make && ./ghpc create tst.yaml -w --skip-validators=test_tf_version_for_slurm
**************** building ghpc ************************
Creating deployment folder "orlovtst" ...
To deploy your infrastructure please run:

./ghpc deploy orlovtst ...

@mr0re1 mr0re1 added the do-not-merge Block merging of this PR label Jul 17, 2024
@mr0re1 mr0re1 requested a review from nick-stroud July 17, 2024 22:40
@mr0re1 mr0re1 force-pushed the tf_version_warning branch from 1d5e3ea to 05602f6 Compare July 17, 2024 22:47
nick-stroud
nick-stroud previously approved these changes Jul 17, 2024
pkg/validators/adhoc.go Outdated Show resolved Hide resolved
@mr0re1 mr0re1 force-pushed the tf_version_warning branch from bf9cc25 to 777374e Compare July 18, 2024 00:17
@mr0re1 mr0re1 merged commit e2feb87 into GoogleCloudPlatform:release-candidate Jul 18, 2024
7 of 48 checks passed
@mr0re1 mr0re1 deleted the tf_version_warning branch July 18, 2024 00:37
@ankitkinra ankitkinra mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Block merging of this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants