Fix construction of cloud.conf
#2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr0re1
added
the
release-bugfix
nick-stroud
added a commit
to nick-stroud/hpc-toolkit
that referenced
this pull request
Jul 26, 2024
This was referenced Jul 26, 2024
sharabiani
pushed a commit
to sharabiani/hpc-toolkit
that referenced
this pull request
Aug 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #2683 accidentally made
TopologyPlugin,SuspendTimeout,SuspendRate,ResumeTimeout, andResumeRateto disappear fromcloud.conf. Fix lookup logic to treat explicitly setnullvalue as "absent".Additionally, remove default value for
tree_widthfrom terraform to enable logic inside python scripts.