Make CloudSQL secret replication configurable #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
mr0re1
reviewed
Jul 30, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/variables.tf
Outdated
Show resolved
Hide resolved
mr0re1
added
the
release-module-improvements
mr0re1
reviewed
Jul 31, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/controller.tf
Show resolved
Hide resolved
tpdownes
reviewed
Jul 31, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/variables.tf
Outdated
Show resolved
Hide resolved
tpdownes
reviewed
Jul 31, 2024
tpdownes
reviewed
Jul 31, 2024
|
/gcbrun |
tpdownes
approved these changes
Aug 9, 2024
tpdownes
force-pushed
the
cloudsql-secret-regions
branch
from
eba09e7 to
0ba99e5
Compare
|
/gcbrun |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the replication configuration of the CloudSQL secret makes it statically global. Customers who are using constraints/gcp.resourceLocations Org Policy to restrict regions are blocked because it forbids global resources:
This proposal is based on HTCondor secret management: 1 2