-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enable-maintenance-reservation flag in slurm to control reservation for scheduled maintenance #2987
Merged
harshthakkar01
merged 1 commit into
GoogleCloudPlatform:develop
from
harshthakkar01:slurm-maintenance
Sep 6, 2024
Merged
Add enable-maintenance-reservation flag in slurm to control reservation for scheduled maintenance #2987
harshthakkar01
merged 1 commit into
GoogleCloudPlatform:develop
from
harshthakkar01:slurm-maintenance
Sep 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr0re1
reviewed
Sep 4, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Sep 4, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Sep 4, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
ed64dc2
to
22c0d78
Compare
mr0re1
reviewed
Sep 4, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
22c0d78
to
5540508
Compare
5540508
to
23365f5
Compare
mr0re1
reviewed
Sep 5, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Sep 5, 2024
community/modules/compute/schedmd-slurm-gcp-v6-nodeset/variables.tf
Outdated
Show resolved
Hide resolved
e078713
to
1c8ba1f
Compare
mr0re1
reviewed
Sep 5, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Sep 5, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
1c8ba1f
to
f11253a
Compare
mr0re1
reviewed
Sep 5, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
mr0re1
approved these changes
Sep 5, 2024
for scheduled maintenance
f11253a
to
ee96846
Compare
9a781df
into
GoogleCloudPlatform:develop
8 of 52 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
enable_reservation_maintenance
flag at nodeset level. Slurm would look at nodeset config and decide whether to reserve node for scheduled maintenance or not.Also, this would ignore running jobs if the it overlaps with the maintenance window and make slurm reservation for maintenance anyway.
For exameple,
Submission Checklist
Please take the following actions before submitting this pull request.