Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch "None" fields in slurm job datetime data for BigQuery #2992

Merged

Conversation

fdmalone
Copy link
Contributor

@fdmalone fdmalone commented Aug 31, 2024

Fixes #2989 in the sense that it returns a valid null value for BigQuery.

@fdmalone fdmalone changed the title Catch None fields in slurm job data. Catch None fields in slurm job data Aug 31, 2024
@fdmalone fdmalone closed this Aug 31, 2024
@fdmalone fdmalone reopened this Sep 4, 2024
@fdmalone fdmalone changed the title Catch None fields in slurm job data Catch "None" fields in slurm job datetime data for BigQuery Sep 4, 2024
@mr0re1
Copy link
Collaborator

mr0re1 commented Sep 4, 2024

@fdmalone thank you for fixing it! LGTM, landing.

@mr0re1 mr0re1 added the release-bugfix Added to release notes under the "Bug fixes" heading. label Sep 4, 2024
@mr0re1 mr0re1 self-assigned this Sep 4, 2024
@mr0re1 mr0re1 enabled auto-merge September 4, 2024 20:16
@mr0re1
Copy link
Collaborator

mr0re1 commented Sep 4, 2024

/gcbrun

@mr0re1 mr0re1 merged commit 4fac295 into GoogleCloudPlatform:develop Sep 4, 2024
12 of 59 checks passed
@rohitramu rohitramu mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants