Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation on cloud-ops-agent installation and stackdriver removal #3029

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Added documentation on cloud-ops-agent installation and stackdriver removal #3029

merged 3 commits into from
Oct 15, 2024

Conversation

jrossthomson
Copy link
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

nick-stroud
nick-stroud previously approved these changes Sep 20, 2024
@nick-stroud
Copy link
Collaborator

/gcbrun

Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrossthomson there are a couple minor changes to make that you can fix by accepting the changes I've suggested

modules/scripts/startup-script/README.md Show resolved Hide resolved
modules/scripts/startup-script/README.md Outdated Show resolved Hide resolved
auto-merge was automatically disabled October 15, 2024 13:51

Head branch was pushed to by a user without write access

Co-authored-by: Tom Downes <tpdownes@users.noreply.github.com>
Co-authored-by: Tom Downes <tpdownes@users.noreply.github.com>
@jrossthomson
Copy link
Contributor Author

@tpdownes

Changes accepted.

@tpdownes
Copy link
Member

/gcbrun

@tpdownes tpdownes self-requested a review October 15, 2024 13:55
@tpdownes tpdownes changed the base branch from main to develop October 15, 2024 14:05
@tpdownes tpdownes enabled auto-merge October 15, 2024 14:05
@tpdownes tpdownes added the release-improvements Added to release notes under the "Improvements" heading. label Oct 15, 2024
@tpdownes tpdownes merged commit 69a0de8 into GoogleCloudPlatform:develop Oct 15, 2024
8 of 55 checks passed
@harshthakkar01 harshthakkar01 mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants