Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multivpc missing region #3046

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

wiktorn
Copy link
Contributor

@wiktorn wiktorn commented Sep 18, 2024

This helps avoid errors like:

Error: cannot determine self_link for subnetwork "***": Cannot determine region: set in this resource, or set provider-level 'region' or 'zone'.

When just use-ing the generated networks.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@cdunbar13 cdunbar13 requested a review from tpdownes September 19, 2024 13:44
@tpdownes tpdownes added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Sep 24, 2024
@tpdownes
Copy link
Member

/gcbrun

@tpdownes tpdownes assigned wiktorn and unassigned tpdownes Sep 24, 2024
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiktorn can you please rebase this off the current state of develop branch? It is missing f3efb5f which is necessary for test to pass

This helps avoid errors like:
Error: cannot determine self_link for subnetwork "***": Cannot determine region:
set in this resource, or set provider-level 'region' or 'zone'.
@wiktorn wiktorn force-pushed the fix_multivpc_region branch from f893a23 to f8c8fd6 Compare September 24, 2024 19:36
@wiktorn
Copy link
Contributor Author

wiktorn commented Sep 24, 2024

@tpdownes Done

@tpdownes
Copy link
Member

/gcbrun

@tpdownes tpdownes self-requested a review September 24, 2024 21:52
@tpdownes tpdownes merged commit 935e9f5 into GoogleCloudPlatform:develop Sep 24, 2024
10 of 53 checks passed
@tpdownes tpdownes mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants