Chrome Remote Desktop: increase resilience of apt operations #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the behavior of Ansible to update the apt cache only if it is stale (more than 1 hour old). In practice, the apt cache is unlikely to be stale because Ansible was just installed by pip, which requires several packages to be installed.
We have observed failures of this module when unattended-upgrades is running simultaneously to the installation of xfce4. This increases the retry duration from 1 minute to 5 minutes and the number of retries from 6 to 10 (a total of 11 attempts). When we adopt ansible-core 2.12 or later, we should use the lock_timeout feature more directly: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/apt_module.html#parameter-lock_timeout
tpdownes
added
the
release-bugfix
Merged
nick-stroud
approved these changes
Oct 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed failures of this module when unattended-upgrades is running simultaneously to the installation of xfce4. There is no solution to this other than to wait. This increases the retry duration from 1 minute to 5 minutes and the number of retries from 6 to 10 (a total of 11 attempts). When we adopt ansible-core 2.12 or later, we should use the lock_timeout feature more directly:
https://docs.ansible.com/ansible/latest/collections/ansible/builtin/apt_module.html#parameter-lock_timeout
Additionally, this changes the behavior of the CRD Ansible playbook to update the apt cache only if it is stale (more than 1 hour old). In practice, the apt cache is unlikely to be stale in this playbook because Ansible was just installed by pip, which requires several packages to be installed. Thus forcing the cache update is both wasteful in time and increases the chance of an error.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.