Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support template file for kueue configuration in kubectl-apply module #3111

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Support template file for kueue configuration in kubectl-apply module #3111

merged 2 commits into from
Oct 10, 2024

Conversation

sharabiani
Copy link
Collaborator

@sharabiani sharabiani commented Oct 9, 2024 •
edited
Loading

Kueue installation in kubectl-apply module now accepts template files as its config file

Manual tests:

  • A cluster provisioned with installing kueue and setting a template file as config for it.
  • Checked the objects in cluster using kuebctl to verify their values are the same as config_template_vars

@sharabiani sharabiani added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Oct 9, 2024
@sharabiani sharabiani requested a review from ankitkinra October 9, 2024 01:10
@sharabiani sharabiani self-assigned this Oct 9, 2024
@sharabiani sharabiani mentioned this pull request Oct 9, 2024
Merged
@sharabiani sharabiani marked this pull request as ready for review October 9, 2024 01:26
@sharabiani sharabiani marked this pull request as draft October 9, 2024 01:27
@sharabiani sharabiani changed the title Support for template files as config added to kueue installation Support template file for kueue configuration in kubectl-apply module Oct 9, 2024
@sharabiani sharabiani marked this pull request as ready for review October 9, 2024 15:06
@sharabiani sharabiani merged commit d316abc into GoogleCloudPlatform:develop Oct 10, 2024
10 of 55 checks passed
@harshthakkar01 harshthakkar01 mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitkinra ankitkinra ankitkinra approved these changes

Assignees

@sharabiani sharabiani

Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharabiani @ankitkinra