Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve dws_flex ux #3122

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

abbas1902
Copy link
Contributor

@abbas1902 abbas1902 commented Oct 10, 2024

Add dws_flex variable to nodeset to improve dws_flex ux, update README.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@mr0re1 mr0re1 assigned abbas1902 and unassigned mr0re1 Oct 10, 2024
@abbas1902 abbas1902 force-pushed the secret_wink branch 3 times, most recently from 1625c24 to bbc85bf Compare October 11, 2024 21:21
@abbas1902 abbas1902 assigned mr0re1 and unassigned abbas1902 Oct 11, 2024
@abbas1902 abbas1902 force-pushed the secret_wink branch 2 times, most recently from bd1024f to ef51466 Compare October 11, 2024 21:43
docs/slurm-dws-flex.md Outdated Show resolved Hide resolved
@mr0re1
Copy link
Collaborator

mr0re1 commented Oct 12, 2024

Nice, LGTM

@mr0re1 mr0re1 assigned abbas1902 and unassigned mr0re1 Oct 12, 2024
@abbas1902 abbas1902 force-pushed the secret_wink branch 2 times, most recently from 72ca77d to 1d8f174 Compare October 14, 2024 17:28
@abbas1902 abbas1902 marked this pull request as ready for review October 14, 2024 17:29
@abbas1902 abbas1902 added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Oct 14, 2024
@abbas1902 abbas1902 merged commit 61ecf55 into GoogleCloudPlatform:develop Oct 15, 2024
8 of 54 checks passed
@abbas1902 abbas1902 deleted the secret_wink branch October 15, 2024 17:45
@harshthakkar01 harshthakkar01 mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants