Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump integration test to support Go 1.23 #3154

Merged

Conversation

mohitchaurasia91
Copy link
Contributor

@mohitchaurasia91 mohitchaurasia91 commented Oct 22, 2024

https://go.dev/dl/

Stable versions

go1.23.2
go1.22.8

test performed

$ cat go123.yaml
---
steps:
- name: "golang:1.23"
  entrypoint: /bin/bash
  args:
  - -c
  - "make ghpc test-engine"
$ gcloud builds submit --config=go123.yaml
# OK

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@mohitchaurasia91 mohitchaurasia91 marked this pull request as ready for review October 23, 2024 02:43
@mohitchaurasia91 mohitchaurasia91 added the release-version-updates Added to release notes under the "Version Updates" heading. label Oct 23, 2024
@mohitchaurasia91 mohitchaurasia91 merged commit a9be4e6 into GoogleCloudPlatform:develop Oct 23, 2024
12 of 59 checks passed
@mohitchaurasia91 mohitchaurasia91 deleted the bump_go_23 branch October 23, 2024 02:58
@rohitramu rohitramu mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version-updates Added to release notes under the "Version Updates" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants